Open
Conversation
DESTDIR builds create a cache file with relative paths, not absolute paths (which is probably safer in general). Ensure this isn't a problem by changing to the root directory before expanding them.
Basically, you can say `lvu set DESTDIR_BUILD on` and Lunar will default to doing a DESTDIR build. You can also put the line "DESTDIR_BUILD=off" or "DESTDIR_BUILD=on" in modules' DETAILS files to force it to work one way or another.
Basically, do everything that uses installwatch twice: once using installwatch, and once using DESTDIR. Also the actual installation of finished packages is moved into create_destdir_install_cache which is almost certainly the wrong place for it, but there it is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install modules by first using the (quite-common) DESTDIR to install the module into a staging directory, creating the cache from that, and then resurrecting the cache, rather than just installing directly onto the main filesystem.